Re: Memory leak on hashed agg rescan

From: "Neil Conway" <neil(dot)conway(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Memory leak on hashed agg rescan
Date: 2008-10-16 19:28:30
Message-ID: b4e5ce320810161228i4c713cc5y9da08b9a34aae19@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 16, 2008 at 5:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It would probably be cleaner to take that logic out of build_hash_table
> altogether, and put it in a separate function to be called by
> ExecInitAgg.

Yeah, I considered that -- makes sense. Attached is the patch I
applied to HEAD, REL8_3_STABLE and REL8_2_STABLE.

Neil

Attachment Content-Type Size
hashed_agg_mem_leak-2.patch application/octet-stream 4.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-10-16 20:00:41 Re: Deriving Recovery Snapshots
Previous Message Andrew Dunstan 2008-10-16 18:28:35 Re: 8.3 .4 + Vista + MingW + initdb = ACCESS_DENIED