Re: [PATCH] Provide more information to filter_prepare

From: Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>
Subject: Re: [PATCH] Provide more information to filter_prepare
Date: 2021-03-29 10:52:01
Message-ID: b4ccd487-ce47-9134-5423-44dcffd1fafe@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29.03.21 12:18, vignesh C wrote:
> But in prepare_filter_cb callback, by stating "other systems ..." it is
> not very clear who will change the GID. Are we referring to
> publisher/subscriber decoding?

Thanks for your feedback. This is not about GIDs at all, but just about
identifying a transaction. I'm out of ideas on how else to phrase that.
Any suggestion?

Maybe we should not try to give examples and reference other systems,
but just leave it at:

The <parameter>ctx</parameter> parameter has the same contents as for
the other callbacks. The parameters <parameter>xid</parameter>
and <parameter>gid</parameter> provide two different ways to identify
the transaction. The later <command>COMMIT PREPARED</command> or
<command>ROLLBACK PREPARED</command> carries both identifiers,
providing an output plugin the choice of what to use.

That is sufficient an explanation in my opinion. What do you think?

Regards

Markus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2021-03-29 10:57:55 Re: Calendar support in localization
Previous Message Pavel Stehule 2021-03-29 10:48:05 Re: Idea: Avoid JOINs by using path expressions to follow FKs