Re: Oddity in EXPLAIN for foreign/custom join pushdown plans

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Oddity in EXPLAIN for foreign/custom join pushdown plans
Date: 2016-08-25 06:10:45
Message-ID: b4b04e83-5eb4-7dd6-2951-32acadea4e7b@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016/08/25 1:08, Robert Haas wrote:
> On Tue, Aug 23, 2016 at 11:18 PM, Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> OK, I think we should fix the issue that postgres_fdw produces incorrect
>> aliases for joining relations shown in the Relations line in EXPLAIN for a
>> join pushdown query like the above) in advance of the 9.6 release, so I'll
>> add this to the 9.6 open items.

> Isn't it a bit late for that?
>
> I'm not eager to have 9.6 get further delayed while we work on this
> issue, and I definitely don't believe that this is a sufficiently
> important issue to justify reverting join pushdown in its entirety.
> We're talking about a minor detail of the EXPLAIN output that we'd
> like to fix, but for which we have no consensus on exactly how to fix
> it, and the fix may involve some redesign. That does not seem like a
> good thing to the week before rc1. Let's just leave this well enough
> alone and work on it for v10.

That's fine with me.

You said upthread, "I don't want to change it at all, neither in 10 or
any later version." That was the reason why I proposed to fix this in 9.6.

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2016-08-25 06:13:24 Re: Collective typos in contrib/postgres_fdw (Was: Re: Incorrect comment in contrib/postgres_fdw/deparse.c)
Previous Message amul sul 2016-08-25 05:53:10 Re: Bug in to_timestamp().