| From: | amul sul <sul_amul(at)yahoo(dot)co(dot)in> |
|---|---|
| To: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alex Ignatov <a(dot)ignatov(at)postgrespro(dot)ru>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in to_timestamp(). |
| Date: | 2016-08-25 05:53:10 |
| Message-ID: | 1349968951.17422721.1472104390685.JavaMail.yahoo@mail.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Artur Zakirov,
0001-to-timestamp-format-checking-v3.patch looks pretty reasonable to me, other than following concern:
#1.
Whitespace @ line # 317.
#2. Warning at compilation;
formatting.c: In function ‘do_to_timestamp’:
formatting.c:3049:37: warning: ‘prev_type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (prev_type == NODE_TYPE_SPACE || prev_type == NODE_TYPE_SEPARATOR)
^
formatting.c:2988:5: note: ‘prev_type’ was declared here
prev_type;
^
You can avoid this by assigning zero (or introduce NODE_TYPE_INVAL ) to prev_type at following line:
256 + prev_type;
Regards,
Amul Sul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2016-08-25 06:10:45 | Re: Oddity in EXPLAIN for foreign/custom join pushdown plans |
| Previous Message | Satoshi Nagayasu | 2016-08-25 05:37:01 | Re: pg_stat_lwlock wait time view |