| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: alternative to PG_CATCH |
| Date: | 2019-11-05 21:05:12 |
| Message-ID: | b4a3bae5-4fe5-a1c2-7349-9b017957d490@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-11-04 16:01, Tom Lane wrote:
> Now that I've actually looked at the patched code, there's a far
> more severe problem with it. Namely, that use of PG_FINALLY
> means that the "finally" segment is run without having popped
> the error context stack, which means that any error thrown
> within that segment will sigsetjmp right back to the top,
> resulting in an infinite loop. (Well, not infinite, because
> it'll crash out once the error nesting depth limit is hit.)
> We *must* pop the stack before running recovery code.
I can confirm that that indeed happens. :(
Here is a patch to fix it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-nested-error-handling-in-PG_FINALLY.patch | text/plain | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-11-05 21:14:40 | Re: Why overhead of SPI is so large? |
| Previous Message | Alvaro Herrera | 2019-11-05 19:19:48 | deferrable FK constraints on partitioned rels |