| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: src/test/regress's check-prepared-txns target |
| Date: | 2017-03-12 03:08:27 |
| Message-ID: | b4a05dd8-c514-ff35-9c67-dfb9e4edcb72@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/11/2017 06:00 PM, Andres Freund wrote:
> Hi,
>
> In https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ae55d9fbe3871a5e6309d9b91629f1b0ff2b8cba
> src/test/regress grew a check-prepared-txns (and an accompanying
> installcheck-prepared-txns) target.
>
> Is that still sensible given that pg_regress actually enables prepared
> transactions? I bet these tests are run just about never.
>
> I'd suggest removing at least check-prepared-txns and adding the test to
> the normal check target (which is guaranteed to have prepared xacts enabled).
>
Sounds reasonable.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-12 03:14:07 | Re: Need a builtin way to run all tests faster manner |
| Previous Message | Robert Haas | 2017-03-12 02:41:57 | Re: Speed up Clog Access by increasing CLOG buffers |