| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some more error location support |
| Date: | 2018-08-27 14:32:42 |
| Message-ID: | b48954ad-c122-64bb-2b3d-44b640f58c56@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27/08/2018 10:53, Fabien COELHO wrote:
> There is a "make_parsestate", but no corresponding free. The usual
> pattern, although there seems to be a few exception, is to "make" and
> "free".
>
> Even if there is some under-the-hood garbage collection, I'd suggest to
> add a free after the call to ComputePartitionAttrs.
Hmm, I didn't know about free_parsestate(). It doesn't seem to be used
consistently. I suppose you'll want to use it when you have a target
relation that will be closed by it, but otherwise, for DDL commands,
it's not all that useful.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-08-27 14:41:38 | Re: pg_dump test instability |
| Previous Message | David G. Johnston | 2018-08-27 14:26:42 | Re: has_table_privilege for a table in unprivileged schema causes an error |