pg_dumpall --exclude-database case folding, was Re: AWS forcing PG upgrade from v9.6 a disaster

On 6/10/21 2:23 PM, Andrew Dunstan wrote:
> On 6/10/21 2:00 PM, Tom Lane wrote:
>> "Dean Gibson (DB Administrator)" <postgresql(at)mailpen(dot)com> writes:
>>> On 2021-06-10 09:54, Ranier Vilela wrote:
>>>> Your cmd lacks =
>>>> =>pg_dumpall -U Admin --exclude-database=MailPen >zzz.sql
>>> I read that before posting, but missed that. Old command line patterns
>>> die hard!
>>> However, the result was the same: 3.5GB before running out of space.
>> [ experiments... ] Looks like you gotta do it like this:
>>
>> pg_dumpall '--exclude-database="MailPen"' ...
>>
>> This surprises me, as I thought it was project policy not to
>> case-fold command-line arguments (precisely because you end
>> up needing weird quoting to prevent that).
>>
>>
>
>
> Ouch. That looks like a plain old bug. Let's fix it. IIRC I just used
> the same logic that we use for pg_dump's --exclude-* options, so we need
> to check if they have similar issues.
>
>

Peter Eisentraut has pointed out to me that this is documented, albeit a
bit obscurely for pg_dumpall. But it is visible on the pg_dump page.

Nevertheless, it's a bit of a POLA violation as we've seen above, and
I'd like to get it fixed, if there's agreement, both for this pg_dumpall
option and for pg_dump's pattern matching options.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com