Re: [PATCH] Add pretty-printed XML output option

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrey Borodin <amborodin86(at)gmail(dot)com>
Subject: Re: [PATCH] Add pretty-printed XML output option
Date: 2025-05-22 15:34:42
Message-ID: b43a6aff-cf96-4146-8816-32f9042efd71@uni-muenster.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 22.05.25 17:00, Tom Lane wrote:
> Yeah, after sleeping on it I fear that leaving xml_parse entirely
> alone will just be a recipe for future copy-and-paste errors.
That's exactly my concern as well.
> The Assert solution seems like the way to go, approximately
>
> xmlNodePtr root;
> + xmlNodePtr oldroot PG_USED_FOR_ASSERTS_ONLY;
>
> ...
> /* This attaches root to doc, so we need not free it separately. */
> - xmlDocSetRootElement(doc, root);
> + oldroot = xmlDocSetRootElement(doc, root);
> + /* ... and there can't yet be any old root to clean up. */
> + Assert(oldroot == NULL);
>
> I'll make it so.

+1

Thanks!

Best regards, Jim

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shaik Mohammad Mujeeb 2025-05-22 15:43:30 Re: [Util] Warn and Remove Invalid GUCs
Previous Message Yasir 2025-05-22 15:30:34 Re: Why our Valgrind reports suck