Re: buildfarm windows checks / tap tests on windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: buildfarm windows checks / tap tests on windows
Date: 2021-03-03 15:18:44
Message-ID: b404d5f4-0bb0-e0b4-2f8a-c83e5628051f@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 3/2/21 3:57 PM, Andres Freund wrote:
>
>>> This makes it even clearer to me that we really need a builtin
>>> testrunner that runs tests efficiently *and* debuggable on windows.
>>>
>> "show me the code" :-)
> The biggest obstacle on that front is perl. I started to write one, but
> hit several perl issues within an hour. I think I might write one in
> python, that'd be a lot less painful.

Without knowing details I'm skeptical. Over nearly three decades of
using perl I have found very little I wanted to do that I could not.

>
>
> One windows build question I have is why the msvc infrastructure doesn't
> accept msys perl in places like this:
> guid => $^O eq "MSWin32" ? Win32::GuidGen() : 'FAKE',
> If I change them to accept msys perl then the build ends up working.
>
> The reason it'd be nice to accept msys perl is that git for windows
> bundles that - and that's already installed on most CI projects...

Nice idea, but we can't run prove under Git's msys perl, because it's
missing some stuff, at least on drongo:

C:\prog>bin\prove --version

C:\prog>"c:\Program Files\Git\usr\bin\perl" "c:\Program
Files\Git\usr\bin\core_perl\prove" --version
Can't locate TAP/Harness/Env.pm in @INC (you may need to install the
TAP::Harness::Env module) (@INC contains: /usr/lib/perl5/site_perl
/usr/share/perl5/site_perl /usr/lib/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl
/usr/share/perl5/core_perl) at /usr/share/perl5/core_perl/App/Prove.pm
line 6.
BEGIN failed--compilation aborted at
/usr/share/perl5/core_perl/App/Prove.pm line 6.
Compilation failed in require at c:\Program
Files\Git\usr\bin\core_perl\prove line 9.
BEGIN failed--compilation aborted at c:\Program
Files\Git\usr\bin\core_perl\prove line 9.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2021-03-03 15:22:28 pg_amcheck contrib application
Previous Message Daniel Gustafsson 2021-03-03 15:18:39 Re: Fix DROP TABLESPACE on Windows with ProcSignalBarrier?