| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Some efforts to get rid of "long" in our codebase |
| Date: | 2025-11-06 18:33:12 |
| Message-ID: | b4046cdb-7eb6-4eb4-93e1-c00b7141ee22@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.11.25 12:46, David Rowley wrote:
> 0002: MemSet / MemSetAligned macros. It's probably about time someone
> made these disappear, but that's likely for another thread with more
> research than I'd like to do here. I replaced "long" with "Size". I
> also considered "uintptr_t", but after some reading of the C standard,
> I settled on Size as it seems it's possible for platforms to exist
> where the pointer width is smaller than the processor's width. I
> suspect it might not matter for the platforms we support? Size could
> also be smaller than the processor's width, but I feel that's less
> likely.
I think size_t/Size could be misleading here. You're not measuring any
size, you're just chunking up the bytes to zero into something that we
thing the compiler or CPU can handle very efficiently.
So in a sense, using long isn't wrong here. It might well be the best
for this. If there is an aversion to using any long at all, why not
long long.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-11-06 18:35:34 | Re: Extended Statistics set/restore/clear functions. |
| Previous Message | Peter Eisentraut | 2025-11-06 18:26:38 | Re: Some efforts to get rid of "long" in our codebase |