| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: backend *.c #include cleanup (IWYU) |
| Date: | 2024-02-12 16:08:40 |
| Message-ID: | b3e514f8-4fa3-4a1f-b3c2-7dcb3cd9b20b@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10.02.24 21:13, Nathan Bossart wrote:
>> (Interestingly, IWYU has been mentioned in src/tools/pginclude/README since
>> 2012. Has anyone else played with it? Was it not mature enough back then?)
> I haven't played with it at all, but the topic reminds me of this thread:
>
> https://postgr.es/m/flat/CALDaNm1B9naPDTm3ox1m_yZvOm3KA5S4kZQSWWAeLHAQ%3D3gV1Q%40mail.gmail.com
Approaches like that as well as the in-tree pgrminclude work by "I
removed the #include and it still compiled fine", which can be
unreliable. IWYU on the other hand has the compiler tracking where a
symbol actually came from, and so if it says that an #include is not
used, then it's pretty much correct by definition.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-02-12 16:08:47 | Re: cpluspluscheck complains about use of register |
| Previous Message | Tom Lane | 2024-02-12 15:59:58 | Re: clarify equalTupleDescs() |