| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - add SHOW_ALL_RESULTS option |
| Date: | 2022-03-22 15:01:17 |
| Message-ID: | b3b4a89f-9dd8-dcc3-d75d-118ec80ce471@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17.03.22 19:04, Fabien COELHO wrote:
> Indeed! The missing part was put back in v17.
Some unrelated notes on this v17 patch:
-use Test::More;
+use Test::More tests => 41;
The test counts are not needed/wanted anymore.
+
+\set ECHO none
+
This seems inappropriate.
+--
+-- autocommit
+--
+--
+-- test ON_ERROR_ROLLBACK
+--
This test file already contains tests for autocommit and
ON_ERROR_ROLLBACK. If you want to change those, please add yours into
the existing sections, not make new ones. I'm not sure if your tests
add any new coverage, or if it is just duplicate.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-03-22 15:08:44 | Re: Use generation context to speed up tuplesorts |
| Previous Message | Daniel Gustafsson | 2022-03-22 14:55:59 | Re: SQL/JSON: JSON_TABLE |