Re: shared-memory based stats collector

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, andres(at)anarazel(dot)de
Cc: ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: shared-memory based stats collector
Date: 2018-10-30 12:35:23
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On 10/05/2018 10:30 AM, Kyotaro HORIGUCHI wrote:
> Hello.
> At Tue, 02 Oct 2018 16:06:51 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20181002(dot)160651(dot)117284090(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
>> It doesn't work nor even compile since I failed to include some
>> changes. The atached v6-0008 at least compiles and words.
>> 0001-0007 are not attached since they are still aplicable on
>> master head with offsets.
> In this patchset 0001-0007 are still the same with the previous
> version. I'll reorganize the whole patchset in the next version.
> This is more saner version of previous v5-0008, which didn't pass
> regression test. v6-0008 to v6-0010 are attached and they are
> applied on top of v5-0001-0007.

BTW one more thing - I strongly recommend always attaching the whole
patch series, even if some of the parts did not change.

Firstly, it makes the reviewer's life much easier, because it's not
necessary to hunt through past messages for all the bits and resolve
potential conflicts (e.g. there are two 0008 in recent messages).

Secondly, it makes work - it tries to
apply patches from a single message, which fails when some of the parts
are omitted.


Tomas Vondra
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2018-10-30 12:48:15 Re: pgbench doc fix
Previous Message Axel Rau 2018-10-30 12:31:29 Re: Getting fancy errors when accessing information_schema on 10.5