Re: Allow pg_archivecleanup to remove backup history files

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, masao(dot)fujii(at)oss(dot)nttdata(dot)com, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow pg_archivecleanup to remove backup history files
Date: 2023-06-20 13:27:36
Message-ID: b367dba446c2859358b15a5e18e4f165@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-06-19 14:37, Michael Paquier wrote:
> On Mon, Jun 19, 2023 at 11:24:29AM +0900, torikoshia wrote:
>> Thanks, now I understand what you meant.
>
> If I may ask, why is the refactoring of 0003 done after the feature in
> 0002? Shouldn't the order be reversed? That would make for a cleaner
> git history.
> --
> Michael

Agreed.
Reversed the order of patches 0002 and 0003.

--
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

Attachment Content-Type Size
v9-0001-Introduce-pg_archivecleanup-into-getopt_long.patch text/x-diff 4.0 KB
v9-0002-Refactored-to-reduce-the-nesting-level.patch text/x-diff 5.3 KB
v9-0003-Allow-pg_archivecleanup-to-remove-backup-history-.patch text/x-diff 10.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2023-06-20 14:56:12 Re: Do we want a hashset type?
Previous Message Andrew Dunstan 2023-06-20 13:21:14 Re: run pgindent on a regular basis / scripted manner