From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: postgres_fdw bug in 9.6 |
Date: | 2016-12-27 03:40:04 |
Message-ID: | b3276c2e-36f2-fecc-838f-2e9c8e6b37b5@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2016/12/21 21:44, Etsuro Fujita wrote:
> On 2016/12/20 0:37, Tom Lane wrote:
>> Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
>>> On 2016/12/17 1:13, Tom Lane wrote:
>>>> So I think the rule could be
>>>> "When first asked to produce a path for a given foreign joinrel,
>>>> collect
>>>> the cheapest paths for its left and right inputs, and make a
>>>> nestloop path
>>>> (or hashjoin path, if full join) from those, using the join quals
>>>> needed
>>>> for the current input relation pair.
>>> Seems reasonable.
>>>> Use this as the fdw_outerpath for
>>>> all foreign paths made for the joinrel."
>>> I'm not sure that would work well for foreign joins with sort orders.
>>> Consider a merge join, whose left input is a 2-way foreign join with a
>>> sort order that implements a full join and whose right input is a sorted
>>> local table scan. If the EPQ subplan for the foreign join wouldn't
>>> produce the right sort order, the merge join might break during EPQ
>>> rechecks (note that in this case the EPQ subplan for the foreign join
>>> might produce more than a single row during an EPQ recheck).
>> How so? We only recheck one row at a time, therefore it can be
>> claimed to
>> have any sort order you care about.
> I'll have second thoughts about that.
I noticed I was wrong and you are right. Sorry for the noise.
Best regards,
Etsuro Fujita
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-12-27 03:41:09 | Commit fest 2017-01 will begin soon! |
Previous Message | Kyotaro HORIGUCHI | 2016-12-27 03:23:44 | Re: IF (NOT) EXISTS in psql-completion |