Re: Support TRUNCATE triggers on foreign tables

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Support TRUNCATE triggers on foreign tables
Date: 2022-07-07 15:54:37
Message-ID: b2f6d778-7aff-5e0b-4e09-d0b76fa25e9c@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022/06/30 19:38, Yugo NAGATA wrote:
> Hello,
>
> I propose supporting TRUNCATE triggers on foreign tables
> because some FDW now supports TRUNCATE. I think such triggers
> are useful for audit logging or for preventing undesired
> truncate.
>
> Patch attached.

Thanks for the patch! It looks good to me except the following thing.

<entry align="center"><command>TRUNCATE</command></entry>
<entry align="center">&mdash;</entry>
- <entry align="center">Tables</entry>
+ <entry align="center">Tables and foreign tables</entry>
</row>

You added "foreign tables" for BEFORE statement-level trigger as the above, but ISTM that you also needs to do that for AFTER statement-level trigger. No?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2022-07-07 16:06:18 Re: Add a test for "cannot truncate foreign table"
Previous Message Tom Lane 2022-07-07 15:48:20 Re: archive modules