| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: maximum number of backtrace frames logged by backtrace_functions |
| Date: | 2022-02-03 05:33:12 |
| Message-ID: | b22cd3c0-d76b-0379-5971-8637b65b8e87@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On 2022/02/02 16:20, Peter Eisentraut wrote:
> On 01.02.22 18:04, Fujii Masao wrote:
>> The maximum number of backtrace frames logged by backtrace_functions is 100. Isn't it better to document this information so that users can understand not all backtrace always can be logged? Patch attached.
>
> The 100 was chosen as more than you'll ever need. If you are encountering cases with more than that, let's increase the limit.
I encountered the "more than 100 backtrace frames" case when investigating the bug of pg_log_query_plan() patch [1]. Since the function that the patch added can be called repeatedly during call to that function, the backtrace became larger than 100. I think this is not general case, so basically 100 sounds enough limit size to me.
OTOH I think it's helpful if the limit is documented when I occasionally encounter the case and want to understand why all backtrace frames are not logged.
[1]
https://commitfest.postgresql.org/37/3142/
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-02-03 09:30:00 | Re: maximum number of backtrace frames logged by backtrace_functions |
| Previous Message | Bruce Momjian | 2022-02-03 02:54:48 | Re: Conventions |