Re: Online checksums patch - once again

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Online checksums patch - once again
Date: 2020-10-05 12:14:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Replying to an older message in this thread:

>> + /*
>> + * If we reach this point with checksums in inprogress state, we notify
>> + * the user that they need to manually restart the process to enable
>> + * checksums. This is because we cannot launch a dynamic background worker
>> + * directly from here, it has to be launched from a regular backend.
>> + */
>> + if (ControlFile->data_checksum_version == PG_DATA_CHECKSUM_INPROGRESS_VERSION)
>> + ereport(WARNING,
>> + (errmsg("checksum state is \"inprogress\" with no worker"),
>> + errhint("Either disable or enable checksums by calling the
>> pg_disable_data_checksums() or pg_enable_data_checksums()
>> functions.")));
>> This seems pretty half-baked.
> I don't disagree with that. However, given that enabling checksums is a pretty
> intensive operation it seems somewhat unfriendly to automatically restart. As
> a DBA I wouldn't want that to kick off without manual intervention, but there
> is also the risk of this being missed due to assumptions that it would restart.
> Any ideas on how to treat this?
> If/when we can restart the processing where it left off, without the need to go
> over all data again, things might be different wrt the default action.

The later patch version do support restarting, so I think we should
revisit this issue. I would expect the checksums worker to be
automatically started at postmaster startup. Can we make that happen?

- Heikki

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-10-05 12:23:07 Re: [HACKERS] Custom compression methods
Previous Message Amit Kapila 2020-10-05 11:50:26 Re: [Patch] Optimize dropping of relation buffers using dlist