From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Pierre Giraud <pierre(dot)giraud(at)dalibo(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, depesz(at)depesz(dot)com, depesz(at)gmail(dot)com |
Subject: | Re: [PG13] Planning (time + buffers) data structure in explain plan (format text) |
Date: | 2020-08-21 11:52:34 |
Message-ID: | b10c76ce-ae6d-85ff-b185-10b00567d4ed@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020/08/21 14:54, Pierre Giraud wrote:
> Le 20/08/2020 à 17:41, Fujii Masao a écrit :
>>
>>
>> On 2020/08/20 22:34, Julien Rouhaud wrote:
>>> On Thu, Aug 20, 2020 at 12:29 PM David Rowley <dgrowleyml(at)gmail(dot)com>
>>> wrote:
>>>>
>>>> On Thu, 20 Aug 2020 at 19:58, Fujii Masao
>>>> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>>>>
>>>>> On 2020/08/20 13:00, David Rowley wrote:
>>>>>> I forgot to mention earlier, you'll also need to remove the part in
>>>>>> the docs that mentions BUFFERS requires ANALYZE.
>>>>>
>>>>> Thanks for the review! I removed that.
>>>>> Attached is the updated version of the patch.
>>>>> I also added the regression test performing "explain (buffers on)"
>>>>> without "analyze" option.
>>>>
>>>> Looks good to me.
>>>
>>> Looks good to me too.
>>
>> David and Julien, thanks for the review! I'd like to wait for
>> Pierre's opinion about this change before committing the patch.
>>
>> Pierre,
>> could you share your opinion about this change?
>
> It looks good to me too. Thanks a lot!
Pushed. Thanks!
> Let's not forget to notify Hubert (depesz) once integrated.
You're going to do that?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Andrey Lepikhov | 2020-08-21 12:19:06 | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
Previous Message | Ashutosh Bapat | 2020-08-21 11:47:31 | Re: [POC]Enable tuple change partition caused by BEFORE TRIGGER |