Re: Adding type info etc for inheritance errmsg: "child table is missing column ..."

From: Vik Fearing <vik(at)2ndquadrant(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ryan Murphy <ryanfmurphy(at)gmail(dot)com>
Cc: PostgreSQL DEV mailing list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding type info etc for inheritance errmsg: "child table is missing column ..."
Date: 2017-01-07 19:54:43
Message-ID: b08c94f9-048d-1f7c-c33b-b2486906861e@2ndquadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/07/2017 08:15 PM, Tom Lane wrote:
> Ryan Murphy <ryanfmurphy(at)gmail(dot)com> writes:
>> I was hoping for
>> user=# alter table temp inherit entity;
>> ERROR: child table is missing column "id" uuid default uuid_generate_v1mc()
>> Is there an easy way to get the string that includes all those additional
>> constraints/defaults etc?
>
> No, and TBH I would vote strongly against including that much detail in
> this error message anyway. That info could be indefinitely long, and it's
> not especially relevant to the stated error condition --- for example, the
> presence of a default is *not* relevant to whether the column matches the
> parent. I'm okay with shoehorning column type into this message, but not
> much more than that.

I agree.

Perhaps the ERROR message should remain as is, and a DETAIL or HINT line
could be emitted with the entire column definition (or close to it)?
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-01-07 22:05:02 Re: Adding type info etc for inheritance errmsg: "child table is missing column ..."
Previous Message Ryan Murphy 2017-01-07 19:16:55 Re: Adding type info etc for inheritance errmsg: "child table is missing column ..."