Re: Reorganize GUC structs

On 24.10.25 14:21, Heikki Linnakangas wrote:
>> @@ -261,15 +261,15 @@ static bool
>> assignable_custom_variable_name(const char *name, bool skip_errors,
>>                                              int elevel);
>>  static void do_serialize(char **destptr, Size *maxbytes,
>>                           const char *fmt,...) pg_attribute_printf(3, 4);
>> -static bool call_bool_check_hook(const struct config_bool *conf, bool
>> *newval,
>> +static bool call_bool_check_hook(const struct config_generic *conf,
>> bool *newval,
>>                                   void **extra, GucSource source, int
>> elevel);
>> -static bool call_int_check_hook(const struct config_int *conf, int
>> *newval,
>> +static bool call_int_check_hook(const struct config_generic *conf,
>> int *newval,
>>                                  void **extra, GucSource source, int
>> elevel);
>> -static bool call_real_check_hook(const struct config_real *conf,
>> double *newval,
>> +static bool call_real_check_hook(const struct config_generic *conf,
>> double *newval,
>>                                   void **extra, GucSource source, int
>> elevel);
>> -static bool call_string_check_hook(const struct config_string *conf,
>> char **newval,
>> +static bool call_string_check_hook(const struct config_generic *conf,
>> char **newval,
>>                                     void **extra, GucSource source,
>> int elevel);
>> -static bool call_enum_check_hook(const struct config_enum *conf, int
>> *newval,
>> +static bool call_enum_check_hook(const struct config_generic *conf,
>> int *newval,
>>                                   void **extra, GucSource source, int
>> elevel);
>
> The new signatures for these function are less specific than before,
> making them a little worse IMO. Overall +1 on the patches, despite that
> little drawback.

Thanks, pushed.