Re: Assertion failure in update_local_synced_slot(), slotsync.c:364

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Zhijie Hou <houzhijie22(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Assertion failure in update_local_synced_slot(), slotsync.c:364
Date: 2026-11-17 08:45:52
Message-ID: avwUQBo4Ld221QDe@bdtpg
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Mon, Nov 16, 2026 at 04:09:44PM +0800, Zhijie Hou wrote:
>
> Attached is the v3 patch set (with the TAP test split into 0002). Please let
> me know what you think.

Thanks for the new patch!

I've one nit comment:

+ if (slot->data.persistency == RS_TEMPORARY && !found_consistent_snapshot)
+ {
+ ereport(LOG,

When no attempt is made to build a consistent snapshot, this could still be
emitted on every sync cycle. So I wonder if DEBUG1 wouldn't be enough here?

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2026-11-17 08:52:44 Incorrect CONTEXT reported for errors during REPACK CONCURRENTLY
Previous Message Peter Smith 2026-11-17 08:40:21 Re: Initial table sync copies the whole table when it is no longer published