| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Forget the prefetcher's current record in XLogPrefetcherBeginRea |
| Date: | 2026-11-20 05:44:53 |
| Message-ID: | av_eVdzADOxQUVzO@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Nov 19, 2026 at 06:23:46PM +0000, Tomas Vondra wrote:
> Forget the prefetcher's current record in XLogPrefetcherBeginRead()
>
> XLogPrefetcherBeginRead() reset the decoder's record queue, but not
> prefetcher->record, whose block references XLogPrefetcherNextBlock()
> examines. The next read then continued with the remaining block
> references of that stale record, before decoding the record at the new
> read position.
Since this commit, the buildfarm is unstable on various branches for
various hosts, for branches up to 17. Two examples:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=longfin&dt=2026-11-20%2005%3A13%3A08
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=indri&dt=2026-11-20%2005%3A00%3A27
And here is your failure, from the logs of the standby host in test
061:
2026-11-20 00:07:37.476 EST [33350:1] LOG: invalid value for
parameter "maintenance_io_concurrency": 1
2026-11-20 00:07:37.476 EST [33350:2] DETAIL:
"maintenance_io_concurrency" must be set to 0 on platforms that lack
posix_fadvise().
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-11-20 06:15:34 | pgsql: psql: Fix out-of-bounds reads in prompt expansion |
| Previous Message | Michael Paquier | 2026-11-20 04:47:02 | pgsql: Pin relations in phase 1 of REINDEX CONCURRENTLY |