| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Devrim Gündüz <devrim(at)gunduz(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Misleading error message for REPACK USING INDEX on shared catalogs |
| Date: | 2026-11-11 15:53:54 |
| Message-ID: | avSPWNPUiPgctmua@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Sep-23, Álvaro Herrera wrote:
> On 2026-Sep-23, Chao Li wrote:
> > But I have concern with the change. cluster_rel() is used by both
> > REPACK and CLUSTER commands, but CLUSTER command, the syntax is
> > CLUSTER … USING index-name.
>
> Yeah, I think we should keep the "cannot execute %s on a shared catalog"
> string as is, and make the SQL bit interpolated there be REPACK USING
> INDEX or CLUSTER according to stmt->cmd; one because CLUSTER also allows
> the older CLUSTER ON syntax AFAIR, but also you can't do CLUSTER with no
> index.
Pushed like this, thanks.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"I suspect most samba developers are already technically insane...
Of course, since many of them are Australians, you can't tell." (L. Torvalds)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-11-11 15:55:43 | Re: Fix resource leaks in pg_receivewal on LZ4 close failures |
| Previous Message | Tomas Vondra | 2026-11-11 15:53:48 | Re: Two bugs in reconsider_full_join_clause(), handling coalesce() = const clauses |