| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Manu <manuelreyesbravo(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, Richard Guo <rguo(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |
| Date: | 2026-11-11 15:47:06 |
| Message-ID: | avSM5ih6_gSk5DJS@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Also, the comment in MergeAttributes is ... not wrong, but doesn't
really flow with the code, I think. How about a change like this?
* Same rules as above: generated-ness has to match the
- * parent, but the contents of the generation expression
- * can be different, except for virtual generated columns
- * (see CheckPartitionVirtualGeneratedExprs).
+ * parent. We don't check the expression itself here;
+ * CheckPartitionVirtualGeneratedExprs will do so.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-11-11 15:52:38 | pgsql: REPACK: Reword complaint about shared relations |
| Previous Message | Álvaro Herrera | 2026-11-11 15:41:34 | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-11-11 15:53:48 | Re: Two bugs in reconsider_full_join_clause(), handling coalesce() = const clauses |
| Previous Message | Álvaro Herrera | 2026-11-11 15:41:34 | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |