| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com> |
| Subject: | Re: Logical Implication |
| Date: | 2026-11-18 22:17:12 |
| Message-ID: | av4j6LHrlJjI-Bs6@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 17, 2026 at 04:19:36PM -0600, Nathan Bossart wrote:
> I spent some time on the main patch and came up with the following. I
> think it's in decent shape, but it probably ought to go through another
> round of both human and LLM review.
Besides a missing update in the documentation, the only other thing the LLM
found that seemed worth fixing was to handle IMPLIES in
simplify_or_arguments(), and even that seems unlikely to matter much with
realistic usage.
It also found that using IMPLIES with BETWEEN (e.g., ROWS BETWEEN
implies(1) PRECEDING AND CURRENT ROW) is now a syntax error. This feels
like the sort of thing we probably wouldn't have ever noticed without an
LLM, and fixing it seems to require breaking something else, so IMHO we
should just leave it alone. I'll give it another try to be sure, though.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-IMPLIES-logical-operator.patch | text/plain | 20.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Koshino Taiki | 2026-11-18 22:25:54 | Re: Proposal: Include CHECK constraint expression in violation error DETAIL |
| Previous Message | Bryan Green | 2026-11-18 22:09:52 | Re: [RFC] An ETW backend for the static probes on Windows |