| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXPLAIN ANALYZE CREATE TABLE AS EXECUTE runs non-SELECT prepared statements |
| Date: | 2026-11-20 05:00:51 |
| Message-ID: | av/UA+lOZaRo0P+7@bdtpg |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Nov 19, 2026 at 09:51:55AM +0000, Zsolt Parragi wrote:
> Hello
>
> CREATE TABLE AS EXECUTE only accepts a prepared SELECT, rejecting
> anything else with "prepared statement is not a SELECT". EXPLAIN
> ANALYZE doesn't have the same check, so it runs whatever the prepared
> statement is.
>
> This is another issue I found while working on EXPLAIN ANALYZE CTAS
> event triggers [1].
>
> Simple repro:
>
> CREATE TABLE src (a int);
> PREPARE ins AS INSERT INTO src VALUES (1) RETURNING *;
> CREATE TABLE t1 AS EXECUTE ins; -- ERROR: prepared statement is not a SELECT
> EXPLAIN ANALYZE CREATE TABLE t2 AS EXECUTE ins; -- inserts, creates t2
> with the RETURNING rows
>
> It seems clearly wrong, and the plain EXPLAIN variant also happily
> shows the plan of something CREATE TABLE AS would reject.
>
> The attached patch adds the same check to ExplainExecuteQuery. It goes
> back to 9dbf2b7d75d, and the fix is small enough to backpatch.
Agreed, that's an oversight in 9dbf2b7d75d. The fix is pretty straightforward
and looks good to me.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Michael Paquier | 2026-11-20 04:47:17 | Re: Index drops during phase 1 of REINDEX CONCURRENTLY |