Re: Fix cumulative WAL statistics double-counting from parallel workers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Lukas Fittl <lukas(at)fittl(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Ahmed Gouda <gouda0x(at)gmail(dot)com>, Bernd Reiß <bd_reiss(at)gmx(dot)at>
Subject: Re: Fix cumulative WAL statistics double-counting from parallel workers
Date: 2026-11-04 07:32:10
Message-ID: aurfeqkq2dgqvdZK@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 03, 2026 at 04:56:43PM -0800, Lukas Fittl wrote:
> The only way to avoid extra work in InstrStopNode is to have a global
> that represents what pgWalUsage currently is (leader + worker), but
> maybe I'm missing something in your argument?

Speaking HEAD-only here, I still think that accumulating the worker
numbers in pgWalUsage is an abuse of the facility. I'm finding this
point to be what itches me the most regarding this thread.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Lukas Fittl 2026-11-04 07:49:03 Re: Fix cumulative WAL statistics double-counting from parallel workers
Previous Message vignesh C 2026-11-04 07:30:24 Re: Hash index corruption and CLOG lookup errors from checkpoint races