Re: Racing in ROLLBACK PREAPRED and checkpoint

On Thu, Oct 29, 2026 at 12:00:56AM -0400, shihao zhong wrote:
> The commit side has had this since the two-phase commit went in. The abort
> side was written like a regular abort, and its comment says the pg_xact
> update "is not absolutely necessary". That is true for a regular abort,
> but here the state file can bring the transaction back.
>
> This needs to be backported to 14.

As far as I can see, that's pretty old. Dragging into the history of
the code, this issue is at least as old as 9c9b619473cd where the
inCommit flag has been introduced in replacement for the LWLocks.
It's as old as the introduction of 2PC back in 2005.

I'll spend a bit more time on that today, but your suggestion of just
relying on delayChkptFlags should do it, like the COMMIT PREPARED
path.
--
Michael