Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, 1217816127(at)qq(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, PG Bug reporting form <noreply(at)postgresql(dot)org>
Subject: Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a
Date: 2026-10-30 08:41:20
Message-ID: auRYMA9y5QQkx2_e@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Oct 22, 2026 at 09:17:59PM -0400, shihao zhong wrote:
> Thanks. v4 shortens the comments on both callbacks and in the tests,
> and makes report_ext_stats_not_computed() static inline. Nothing else
> changed.

Thanks for the patch, and my apologies for the time it took to come
back here. I have reworked the thing quite a bit, adjusting and
improving the code and comments, and applied it down to v14. The
README of the test module also lacked an update.

Note that the test uses a check based on d.stxoid to see if there is
any data at all, which was stronger than your suggestion. v14 has
kept the stxdexpr, though.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message mingjie gao 2026-10-30 09:50:28 Re: BUG #19821: pg_restore_attribute_stats() accepts an unsorted scalar histogram_bounds, producing badly wrong row
Previous Message Tender Wang 2026-10-30 08:08:30 Re: BUG #19804: "variable not found in subplan target list", DISTINCT agg over Gather`