| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Lukas Fittl <lukas(at)fittl(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Report buffer access strategies in EXPLAIN |
| Date: | 2026-11-06 08:26:51 |
| Message-ID: | au2PS9ozu9zBUl00@bdtpg |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Nov 05, 2026 at 10:02:13AM -0800, Lukas Fittl wrote:
> On Thu, Nov 5, 2026 at 4:18 AM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> > > > 0004 extracts the lookup of leader and per-worker table scan instrumentation.
> > > > 0005 adds optional buffer access strategy instrumentation for table scans and
> > > > preserves every strategy observed across rescans.
> > > > 0006 adds per-worker table scan instrumentation for sample and TID scans.
> > > > 0007 reports the strategies used by table scans with EXPLAIN (ANALYZE, BUFFERS),
> > > > including parallel workers.
> > > > 0008 reports the strategies used by index, index-only, and bitmap index scans.
> > >
> > > Hmm. These touch the same area of the code as some of the stuff Lukas
> > > Fittl is working on..
> >
> > Yeah, this may require some rebasing. That said, I think their goals are largely
> > orthogonal.
>
> Yep, from a quick glance I don't think this will require a lot of
> coordination, just some rebasing.
Thanks for confirming!
> My work is mainly focused on
> instrument.c and the executor, vs this here happens mainly in
> explain.c and the node-type specific instrumentation. I do also have a
> patch set that I haven't posted yet that reworks how we do parallel
> worker instrumentation reporting more broadly, but I don't see any
> immediate problems that would arise.
Cool, please CC me when you post it so that I don't miss it.
> I'm aiming to do a proper review pass on this patchset as well
> today/tomorrow, but wanted to comment on that quickly :)
Thanks for doing so!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xiaoxuan Li | 2026-11-06 08:40:49 | Re: Improve hash aggregate spilling by writing only the needed columns |
| Previous Message | Bertrand Drouvot | 2026-11-06 08:17:13 | Re: Report buffer access strategies in EXPLAIN |