Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, 1217816127(at)qq(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, PG Bug reporting form <noreply(at)postgresql(dot)org>
Subject: Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a
Date: 2026-10-22 04:22:09
Message-ID: atmPcXaQykv09GMu@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Oct 21, 2026 at 11:23:28PM -0400, shihao zhong wrote:
> Thanks. v3 adds a second typanalyze callback to test_custom_types,
> int_custom_typanalyze_once.

The comments on top of each callback feel super bloated, as much as
the comments you have added in the two sequences of tests. These
could be tweaked much more, IMO..

report_ext_stats_not_computed() could be static inline.

We may want to hear from Tomas as well, as he has already commented on
this thread. There is a big conference in Europe this week, and my
guess is that he's now busy with the event and that it's going to take
some time before we get a reply.

@Tomas: Could you look at the patch once you have the occasion,
please?
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Previous Message Xinlei Zhang 2026-10-22 03:53:40 Re: Cached plan can stay stale indefinitely when an invalidation for a planner-added dependency arrives during planning