| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: libpq: Revert the connection option "servicefile" |
| Date: | 2026-10-18 23:30:02 |
| Message-ID: | atVWemXvylZ_QDpe@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Oct 18, 2026 at 10:35:21PM +0000, Michael Paquier wrote:
> libpq: Revert the connection option "servicefile"
>
> The following commits are reverted:
> * 092f3c63efc6, libpq: Add "servicefile" connection option
> * 6b1c4d326b06, psql: Add variable SERVICEFILE
> * 90354030b8fc, libpq: Fix "servicefile" after fallback to system
> service file
>
> After more review, PGSERVICEFILE is sufficient for the purpose of
> specifying a per-session service file. Some details around this feature
> will need more attention before being actually usable, if we ever get
> down to it.
>
> One independent piece that has been committed during the v19 development
> cycle is df286a5b830a, which is kept in the tree as that was an
> unrelated change.
>
> Reported-by: Sehrope Sarkuni <sehrope(at)jackdb(dot)com>
> Discussion: https://postgr.es/m/CAH7T-aq+U6GDPO8mr3Gga3KzxGpAE=BSLb38x+R8fvWjzF-H8w@mail.gmail.com
> Backpatch-through: 19
I am getting these errors in the PG 19 doc build:
$ make check
/usr/bin/xmllint --nonet --path . --path . --noout --valid postgres.sgml
postgres.sgml:2252: element link: validity error : IDREF attribute linkend references an unknown ID "libpq-connect-servicefile"
postgres.sgml:2411: element link: validity error : IDREF attribute linkend references an unknown ID "app-psql-variables-servicefile"
make: *** [Makefile:204: check] Error 4
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-10-18 23:32:29 | pgsql: doc: Remove "servicefile" from the release notes |
| Previous Message | Michael Paquier | 2026-10-18 22:35:21 | pgsql: libpq: Revert the connection option "servicefile" |