| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash |
| Date: | 2026-10-18 22:09:37 |
| Message-ID: | atVDoabI_3vxU8Rn@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 18, 2026 at 10:00:00AM +0300, Alexander Lakhin wrote:
> But there are also several tests that need extra care:
> src/bin/pg_basebackup/t/030_pg_recvlogical.pl
> src/test/modules/test_aio/t/004_read_stream.pl
> src/test/modules/test_checksums/t/003_standby_restarts.pl
> src/test/recovery/t/007_sync_rep.pl
> src/test/recovery/t/040_standby_failover_slots_sync.pl
> src/test/recovery/t/048_vacuum_horizon_floor.pl
> contrib/test_decoding/t/001_repl_stats.pl
Do we have the buildfarm complaining about any of these? I cannot get
excited to act without a reason to do so.
> e.g.:
> t/001_repl_stats.pl .. 3/?
> # Failed test 'stats file must exist after shutdown'
> # at t/001_repl_stats.pl line 177.
> # Looks like you failed 1 test of 6.
> contrib/test_decoding/tmp_check/log/001_repl_stats_test.log:TRAP: failed
> Assert("!ps->dropped"), File: "pgstat.c", Line: 1775, PID: 1057288
>
> By the way, that sleep makes 001_custom_stats.pl fail even at 31280d96a
> (which introduced the test on 2025-12-08).
This one can also be reproduced without a sleep, and a set of
dedicated steps. See this thread:
https://postgr.es/m/CAN12+YJXE+rEOVo74uM5Ofbj_t_m0DHvd_Mo4ppeHV=aDvvXoQ@mail.gmail.com
Perhaps we should just drop this assertion at the end.. Let's discuss
that on the other thread.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-10-18 22:12:07 | Re: Include schema-qualified names in publication error messages (generalised to all of LR). |
| Previous Message | Iliia Khaprov | 2026-10-18 21:34:31 | Re: [PATCH] Remove useless ORDER BY from scalar subqueries |