Re: Introduce contributor badges: image versioning?

Re: Dave Page
> That's fair, but items 1 to 3 still stand; the VCL limits how long the
> stale pages last, though:

Ack, I'll address these separately.

Re: Magnus Hagander
> Agreed, no need for URL versioning.

Thanks.

> > > - `badge_image` fetches the image and computes its MD5 before it checks
> > > `If-None-Match`; storing the hash would avoid both.
> >
> > badge_image is only reached on a Varnish miss, and on a miss we're
> > almost always about to serve the image anyway. Storing the hash only
> > helps the narrow (?) "Django itself receives a conditional request"
> > case.
>
> No, on the vast majority of misses we'd be serving a 304 Found with no
> content. Every time an image expires in any of the caches it would send a
> conditional request.

Is that enough to warrant storing the MD5 in a separate column? The PG
xx Contributor images I have here are all between 20 and 40kB in size.
(I.e. is that the fix we want?)

> (I have not looked at the rest, so I reserve the right to further review)

There will be patches coming for the other points soon.

Christoph