Re: Incorrect argument passed to buffer_readv_encode_error()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: pgsql-hackers(at)postgresql(dot)org, andres(at)anarazel(dot)de
Subject: Re: Incorrect argument passed to buffer_readv_encode_error()
Date: 2026-10-14 23:53:08
Message-ID: atAV5HGKMSmjt6mP@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 14, 2026 at 08:31:22AM +0200, Antonin Houska wrote:
> Although there's no compiler warning, and probably no correctness issue, I
> think the intended coding was as I propose in the diff attached.

Indeed. That's harmless still inconsistent as this *buffer_invalid
points to error_count in buffer_readv_encode_error, which is assumed
to be a uint8 counter.

I am wondering if this should be backpatched down to v18, actually, at
least to keep the branches consistently in check, or just as a matter
of style.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ben Mejia 2026-10-15 00:01:15 Re: [PATCH] vacuumdb: Add --exclude-database option
Previous Message David Rowley 2026-10-14 23:52:04 Re: Reducing relcache memory usage: deduping index shapes