| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash |
| Date: | 2026-10-08 07:51:28 |
| Message-ID: | asdLgE3PngAqHjI6@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 07, 2026 at 04:55:21PM -0500, Sami Imseih wrote:
> Done. v4 is split into two patches.
I have spent some time on that, still in the middle of it, and for now
I am attaching my edits as of a v5-0003 that can apply on top of your
set of two patches (re-attached, these are untouched).
Another doubt that I have is about test_custom_stats_var_is_own_hash()
and its limited value. It is only a check that mirrors if a custom
stats kind uses its own_hash or not, but that does not seem worthwhile
to me due to the backend side restrictions already in place, so I'd be
tempted to drop it, keeping the test module focused on what it is
doing (insert, drops, create, etc.).
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-pgstat-allow-a-stats-kind-to-use-its-own-dedicate.patch | text/plain | 57.0 KB |
| v5-0002-pgstat-expose-own_hash-in-pg_stat_kind_info.patch | text/plain | 5.8 KB |
| v5-0003-Michael-s-edits.patch | text/plain | 12.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Geier | 2026-10-08 07:52:27 | Re: Improving scalability of Parallel Bitmap Heap/Index Scan |
| Previous Message | Richard Guo | 2026-10-08 07:42:35 | Assert failure in find_var_for_subquery_tle |