Re: Persist slot invalidations before publishing them

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: JoongHyuk Shin <sjh910805(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Rui Zhao <zhaorui126(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Persist slot invalidations before publishing them
Date: 2026-09-30 12:19:15
Message-ID: arz+Qy4Q+9wMtmJo@bdtpg
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Sep 30, 2026 at 09:08:41AM +0530, shveta malik wrote:
> On Tue, Sep 29, 2026 at 1:59 PM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > The static flag looks safe, but I wonder if it wouldn't be clearer to keep
> > ReplicationSlotReleaseInternal() and call it with false from the error path?
> >
> > That would still allow us to remove update_inactive_since from
> > ReplicationSlotPersistInvalidation() and its callers, while keeping the
> > exceptional release behavior explicit.
> >
>
> Okay, works for me.

Thanks, done that way in the attached.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v8-0001-Persist-slot-invalidations-before-publishing-them.patch text/x-diff 28.9 KB
v8-0002-Persist-synchronized-slot-invalidations-before-pu.patch text/x-diff 8.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2026-09-30 12:19:47 Re: Do we need to back-patch tzcode 2026b after all?
Previous Message Ashutosh Sharma 2026-09-30 12:08:41 Re: remote_apply commit hangs when wal_receiver_status_interval = 0