Re: Teach pg_upgrade to deal with invalid databases

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Rithvika Devisetti <devisettirithvika(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>
Subject: Re: Teach pg_upgrade to deal with invalid databases
Date: 2026-10-02 16:21:25
Message-ID: ar_aBTKVbZ-duSbT@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 24, 2026 at 08:37:00AM -0700, Bharath Rupireddy wrote:
> I implemented the above approach, pg_upgrade skipping them without any
> option and emitting info about the skipped ones. I ensured the CI is
> happy. Please find the attached v2 patch.

Thanks. IMHO we shouldn't bother adding a note to pg_upgrade's
documentation, or even emitting warnings when pg_upgrade skips invalid
databases. For all intents and purposes, the database is already dropped
(for some definition of "dropped"), and there's nothing actionable for the
user.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-10-02 16:26:48 Re: Report relation extension blockers within parallel lock groups
Previous Message Manu 2026-10-02 16:19:40 Re: Partial indexes on system catalogs