| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alex Shapalov <shapalov(at)gmail(dot)com>, Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Reset waitStart when a lock wait fails |
| Date: | 2026-09-24 05:09:23 |
| Message-ID: | arSwgp1VLVKpRTV5@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 24, 2026 at 10:37:12AM +0800, Chao Li wrote:
> On Sep 24, 2026, at 09:30, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
>> With the patch it reads NULL. The patch clears it the same way
>> ProcWakeup() does, like 70f470314cb did for the grant path. It applies
>> to 14 and up.
>
> Looks good to me. Once proc->waitLock is cleared, proc->waitStart no
> longer describes an active wait, so clearing it at the same time
> seems right.
Yep, it looks weird to not clean up the field in this code path.
@Fujii-san, what do you think?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-09-24 05:18:49 | RE: [PATCH] Explain what the default output_plugin_libraries do |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-09-24 05:06:01 | RE: [PATCH] Explain what the default output_plugin_libraries do |