| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: [PATCH] Clear FatalError earlier during crash restart |
| Date: | 2026-10-01 04:18:10 |
| Message-ID: | ar3fAireyS3qXz2F@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 30, 2026 at 07:53:12AM +0530, Ayush Tiwari wrote:
> I've kept the helper, but now wait for the new checkpointer to install its
> signal handlers. The helper gets more time too.
Hmm. I am not sure that we actually need to multiply by 4 the restore
timeout sent to the fake restore_command waiting for the shutdown.
Isn't that somewhat betraying the default value of Utils.pm?
> You have a better feel for the backpatch risk here, so I'll defer to you..
HEAD-only feels like better sleep for the time being woth v19 being
close by. Better sleep sounds always good.
I have been doing a bunch of adjustments as of the attached, and that
seems to work properly. The buildfarm would be the final judge; the
CI looks OK with the new test at least. What do you think?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-handling-of-shutdown-requests-during-a-early-.patch | text/plain | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-10-01 04:18:11 | Re: Parallel vacuum: I/O timings in the log leave out the parallel workers |
| Previous Message | vignesh C | 2026-10-01 04:16:01 | Re: Fix apply worker crash when subscriber table has only a deferrable primary key |