Re: injection_points: canceled or terminated waiters leak their wait slots

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: injection_points: canceled or terminated waiters leak their wait slots
Date: 2026-09-30 23:05:20
Message-ID: ar2VsK9d-UJiC7x7@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 30, 2026 at 11:00:26PM +0500, Andrey Borodin wrote:
> I think there's more benefit than possible harm. There are ~4 similar
> failures a month on master. If we resurrect walreceiver problems, we will
> notice soon. There were like ~20 failures a month. And a8458f508a7 commit
> message looks promising (I do not understand commit itself).

Well, as mentioned in this commit, peeking at a socket before sleeping
is qualified as a kludge, probably not the best long-term approach. I
doubt that a lot of people are motivated to redesign the event vs
socket handling just to make for a better socket implementation of
Postgres on WIN32, and I suspect that relying on Thomas's mage skills
should be good enough. FWIW, I trust his skills, and also I have no
plans to dive into this leel of details for the WIN32 issues; there's
more than enough going on.

Now I don't mind running the revert/revert experiment and see how it
goes, at the condition that we make all the branches more stable as a
starting point. Bypassing these tests on WIN32 is part of the plan
I'd be OK with.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Liapychev 2026-09-30 23:14:14 Re: COMMENTS are not being copied in CREATE TABLE LIKE
Previous Message Tom Lane 2026-09-30 22:58:14 Re: [PATCH] intXshr, intXshl: return error on shift count out of range