Re: pg_regress: schedule multi-line test groups

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_regress: schedule multi-line test groups
Date: 2026-09-17 08:03:38
Message-ID: aque2pNHYkJC5iyR@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 17, 2026 at 08:57:51AM +0100, Alexandre Felipe wrote:
> This was motivated by two rebases on the SLOPE patch [1] this week due to
> changes in parallel_schedule. Also I find much easier to parse the list
> using this syntax, if we stick with one test per line we get the benefit of
> counting tests by looking at the line numbers.
>
> I used a `goto` to keep the number of touched lines small, and facilitate
> your review.

I'd +1 something like that in the schedule files, even if we only
limit the number of tests per line to be up to 20.

+test:
+ boolean
+ char
+ name

At least, let's make the whitespace vs tab policy consistent. ;)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Geier 2026-09-17 08:13:28 Re: Use correct collation in pg_trgm
Previous Message Alexandre Felipe 2026-09-17 07:57:51 pg_regress: schedule multi-line test groups