Re: Support for 8-byte TOAST values, round two

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Greg Burd <greg(at)burd(dot)me>
Cc: Rui Zhao <zhaorui126(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support for 8-byte TOAST values, round two
Date: 2026-09-16 00:34:21
Message-ID: aqnkDNytpMUrsTfi@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 15, 2026 at 01:05:09PM -0400, Greg Burd wrote:
> Pinning default_toast_compression in the test would work too, though it costs
> you the coverage of whichever method you did not pin.

Using default_toast_compression is perhaps nicer (same as
portals.sql). It offers more predictibility in the output and we
don't really care about the compression method in this case. The md5
computations can be more expensive, which I find annoying, so I'm
eager to just reuse the smart pattern of toast.sql instead. It's much
cheaper, and enforces the out-of-line behavior we want here.

Note: test_decoding has the same issue. Oops. Will fix in a bit
after more checks.

> Either way this is Michael's call to make, I'm anxious to hear his thoughts
> on this.

Replied to that upthread, as of:
https://www.postgresql.org/message-id/aqni9bvWV0UIUEZy@paquier.xyz

I don't think that this new reloption should equal in expectations
with fillfactor and/or tuple_toast_target.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-09-16 00:38:52 Re: remove_useless_joins vs. bug #19560
Previous Message Michael Paquier 2026-09-16 00:29:41 Re: Support for 8-byte TOAST values, round two