| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Translation of the NextOID message in pg_controldata |
| Date: | 2026-09-14 23:04:33 |
| Message-ID: | aqh9gBSofzn0Ub88@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 14, 2026 at 09:01:27PM +0200, Peter Eisentraut wrote:
> I think the symbol OID8_FORMAT should be purged from the code. Its presence
> is just going to cause confusion, with people using it in incorrect ways,
> and inviting more XXX_FORMAT symbols to be added. We have just been working
> on getting rid of these after all.
Okay. The string idea is discarded then, in profit of some PRIu64 in
these three spots.
Perhaps getting rid of OID8_FORMAT entirely is the best thing to do,
as you suggest. The attached does so, better applied down to v19
that's not been released yet. The xlogdesc.c feels slightly weird,
but perhaps that's OK. WDYT?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-OID8_FORMAT.patch | text/plain | 12.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Daniel Gustafsson | 2026-09-14 21:59:15 | Re: Trying to break online checksums with LLMs |