| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, aleksander(at)timescale(dot)com |
| Subject: | Re: Rename PqMsg_Progress to PqMsg_ParallelWorkerProgress |
| Date: | 2026-09-10 14:32:28 |
| Message-ID: | aqK_fB6as0A_sBQw@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 10, 2026 at 03:20:12PM +0200, Antonin Houska wrote:
> Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>> Well, that's kind of bikeshedding for me to start with. But if we do,
>> maybe a better option will be to describe what this exactly does, not
>> who sends it. Like PgMsg_StatProgressReport or something. Does it
>> sound?
>
> My objection to PqMsg_ParallelWorkerProgress is that other kinds of workers
> might use it too, so PqMsg_WorkerProgress would make more sense. Anyway, your
> suggestion sounds good to me as well because the existing message types do not
> (except for PqMsg_BackendKeyData) use the name to indicate the sender.
I don't think we need to worry too much about other kinds of workers in
this case. The message is already listed under a comment that says it's
for parallel workers. Presumably we'd add new macros for things that other
types of workers send.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-09-10 14:50:14 | Re: pg_*_advice: tsv load failure, etc. |
| Previous Message | Nathan Bossart | 2026-09-10 14:30:33 | Re: Rename PqMsg_Progress to PqMsg_ParallelWorkerProgress |