Re: [PATCH] Optimization: avoid repeated strlen() calls in function CreateTriggerFiringOn when parsing trigger arguments

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Lucas Jeffrey <luquijeffrey(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Optimization: avoid repeated strlen() calls in function CreateTriggerFiringOn when parsing trigger arguments
Date: 2026-09-09 00:40:40
Message-ID: aqCrByxMtpbf0TMz@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 08, 2026 at 09:00:31PM -0300, Lucas Jeffrey wrote:
> foreach(le, stmt->args)
> {
> char *s = strVal(lfirst(le));
> - char *d = args + strlen(args);

While a right suggestion, trigger creation is no critical path. So
why caring?
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Keyerror Smart 2026-09-09 00:46:48 [PATCH] Combine qual-based and NOT NULL proofs when reducing outer joins
Previous Message jian he 2026-09-09 00:40:31 Re: Fix inherited constraint loss in ALTER COLUMN SET EXPRESSION