| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ilya Cherdakov <i(dot)cherdakov(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Assert in test_bms_membership(); |
| Date: | 2026-09-08 22:55:36 |
| Message-ID: | aqCSZ2tgEFKR9-ul@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 08, 2026 at 04:09:27PM -0400, Andres Freund wrote:
> We are drowning in patches, with actual (not AI) review and committer
> bandwidth being the bottleneck. I think showing that we accept patches for
> making test modules not crash when held in bogus ways is a good way to make
> that even worse.
With or without AI, drowning in patches for the past 8 years 4 months
has just been a part of my life. If somebody takes the time to send a
patch, I'll look at it. And here, FWIW, I don't mind much.
> I think using these modules as templates for real extensions tends to be a not
> great idea. I turns out test code, which tends to lean towards testing edge
> cases etc, is rarely nice, easy to understand, code.
Depends, I guess.
Note: the other thread has a patch, let's keep things there.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-08 23:25:14 | Re: Concurrent DROP TABLESPACE can miss a shared dependency |
| Previous Message | Tom Lane | 2026-09-08 22:04:08 | Re: Fix var_eq_const: sum selectivity of all matching MCV entries instead of stopping at first match |