| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix lack of message pluralization |
| Date: | 2026-09-04 05:46:12 |
| Message-ID: | appbJFfMR7S_74C7@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Sep 03, 2026 at 02:51:31PM +0200, Daniel Gustafsson wrote:
> On 3 Sep 2026, at 14:49, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> This is correct, but we have some precedent to pluralize these
>> kinds of things anyway. Several reasons:
>>
>> - Translators shouldn't have to look into the source code what the
>> - actual value is. (Or, in this case, even beyond the actual
>> - source code.)
>>
>> - Maybe tomorrow someone changes this to PG_UINT16_MAX, and then
>> - it might have to be translated differently.
>>
>> - Not in this specific case but in general: You might have the
>> - same message in different contexts but with different numbers.
>
> Makes sense, thanks for explaining!
Commenting as the guy who has touched the trigger code and added this
message. Thanks for the explanation, will keep that in mind.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-04 07:03:51 | pgsql: pg_upgrade: Skip tests for live server checks on Windows |
| Previous Message | Richard Guo | 2026-09-04 01:36:29 | pgsql: Disallow joins whose lateral references need an unformable outer |